eg-attachments

Beskrywing

Hierdie uitbreiding is op Maart 7, 2024 gesluit. Dit is nie beskikbaar om afgelaai te word nie. This closure is temporary, pending a full review.

Aanbevelings

April 27, 2017 1 reply
In database query inside a plugin file is not as per the standard WordPress queries. In file "\eg-attachments\inc\eg-attachments-public.inc.php" there is a function "record_click". In this function author is using below query: $sql = $wpdb->prepare('SELECT click_id,clicks_number FROM wp_eg_attachments_clicks WHERE click_date=CURRENT_DATE() AND attach_id=%d AND post_id=%d', $attach_id, $parent_id); Just look at the query, author is using “wp_eg_attachments_clicks” for a table. Here table prefix for that table is “wp_” which is not dynamic. Author should use something like below: $sql = $wpdb->prepare('SELECT click_id,clicks_number FROM '.$wpdb->prefix.'eg_attachments_clicks WHERE click_date=CURRENT_DATE() AND attach_id=%d AND post_id=%d', $attach_id, $parent_id); In place of "wp_" we should always use "$wpdb->prefix" in our queries so that our query will not break even change of table prefix by the user from wp-config.php file. Request to author, please update it in your next release. Thanks, Sunil Chaudhary
Read all 8 reviews

Contributors & Developers

“EG-Attachments” is oopbron sagteware. Die volgende mense het bygedra tot die ontwikkeling van hierdie uitbreiding:

Contributors

Translate “EG-Attachments” into your language.

Interested in development?

Browse the code, check out the SVN repository, or subscribe to the development log by RSS.